Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SDK #67

Open
SokolovRU opened this issue Nov 26, 2023 · 1 comment
Open

update SDK #67

SokolovRU opened this issue Nov 26, 2023 · 1 comment

Comments

@SokolovRU
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @voximplant/[email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/@voximplant/react-native-foreground-service/android/build.gradle b/node_modules/@voximplant/react-native-foreground-service/android/build.gradle
index 7f9022f..4899a6a 100644
--- a/node_modules/@voximplant/react-native-foreground-service/android/build.gradle
+++ b/node_modules/@voximplant/react-native-foreground-service/android/build.gradle
@@ -6,12 +6,12 @@ def safeExtGet(prop, fallback) {
 }
 
 android {
-    compileSdkVersion 28
-    buildToolsVersion '28.0.3'
+    compileSdkVersion 33
+    buildToolsVersion '33.0.0'
 
     defaultConfig {
-        minSdkVersion 16
-        targetSdkVersion 28
+        minSdkVersion 21
+        targetSdkVersion 33
         versionCode 1
         versionName "1.0"
     }

This issue body was partially generated by patch-package.

@radek-treeline
Copy link

If using yarn, you can patch with following command (follow instructions from terminal):
yarn patch @voximplant/react-native-foreground-service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants