Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less frequent CI runs #366

Open
mbackenkoehler opened this issue May 24, 2023 · 3 comments
Open

Less frequent CI runs #366

mbackenkoehler opened this issue May 24, 2023 · 3 comments
Labels
2023.05.2 (DL edition) [tmp] All PRs for DL edition question Further information is requested

Comments

@mbackenkoehler
Copy link
Collaborator

Currently, the CI runs once a week. With the upcoming DL_edition update the runs become much heavier. So until we have a more fine-grained checking mechanism, we can probably stretch that to once a month.

@mbackenkoehler mbackenkoehler added question Further information is requested 2023.05.2 (DL edition) [tmp] All PRs for DL edition labels May 24, 2023
@dominiquesydow
Copy link
Collaborator

Once a month seems a bit too long for this repo that is being used quite a lot for teaching, in my opinion. Maybe every two weeks? But up to you @AndreaVolkamer.

Whatever you decide, can you please update this in our repo overview accordingly?
https://github.com/volkamerlab/lab_repos_check
Thanks!


If the DL talktorials take too long in the CI, can you think of ways to make this work more elegantly during testing (we do have quite a few notebooks where we adapted the code in a way that it will be less heavy during CI runs --- if you point me to the code in question, I can think about it; nothing that needs to be done for the DL release).

@mbackenkoehler
Copy link
Collaborator Author

Talktorial 36, for example, is timed out.

@mbackenkoehler
Copy link
Collaborator Author

Typically, some of the 4 jobs fail, due to online resources not being reachable for whatever reason. In that case you have to re-start the jobs a couple of times. So each time there is a pretty high probability of manual intervention being necessary.

Maybe it is also possible to add a retrial scheme for notebooks that use such resources (T001, T018...)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023.05.2 (DL edition) [tmp] All PRs for DL edition question Further information is requested
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants