-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stray hash after closing modal #202
Comments
The same here. Any suggestion? |
+1 |
2 similar comments
+1 |
+1 |
Any news on this? Cheers! |
No suggestion? |
I've found a way to fix this problem. In remodal.js find
then add the following code underneath it
so you should have
This clears # from the URL upon closing the popup via the wrapper and buttons as well as replaces the stray hash URL in the browser history buttons. Hope this helps! |
you can add this to Modal wrap [ data-remodal-options="hashTracking: false," ]
|
When a model is closed, a stray hash remains in the URL.
This can be easily worked around by listening for a close event an using replaceState - however I don't thing it's expected behaviour. In fact, I would expect the URL to return to what it was perviously - if the hash is already populated, the last state should return:
The text was updated successfully, but these errors were encountered: