Make scroll lock optional

[TiGR]

It would be nice if locking scrolling was optional. The problem is, though I can override it with CSS, I can't prevent remodal from adding padding to content element. Or is there a way?

Remodal works well this way, and I am pretty fine with background scrollable.

[vodkabears]

body {
  padding-right: 0 !important;
}

[TiGR]

So, it takes this to change the behavior:

body {
    padding-right: 0 !important;
|
.html.remodal-is-locked, body.remodal-is-locked {
    overflow: auto;
}

[ursbraem]

Hi! Remodal is awesome. On a side note, I put it together with https://github.com/aFarkas/lazysizes and it works flawlessly.

I am struggling with the same behaviour (jumping when lock screen is on, cf. #50 as well). The fix works, but it messes up our layout.

I can simply hack the script and turn off lockScreen(); - but then we have two scrollbars.

As getScrollbarWidth() is already doing some work, would it be possible to somehow avoid that jump there? Maybe by adding some more padding of the width of another scrollbar? I've tried messing with the paddingRight in the JS, but I found no effect.

[vodkabears]

As getScrollbarWidth() is already doing some work, would it be possible to somehow avoid that jump there?

Why is 'padding-right' not working for you? lockScreen sets 'padding-right'. If you have absolute or fixed elements try to set it via CSS or get the value of the body padding and set it via JS.

[vodkabears]

Another reason, why it does not work for you, can be this line of the code: https://github.com/VodkaBears/Remodal/blob/master/src/remodal.js#L196. I think, it is more correclty to compare $(document).height() and $(window).height().

[TiGR]

padding-right is not a solution when you have centered background image.

[ursbraem]

Hi, I'm sorry, I lost a little track of the issue. I couldn't answer the question why padding-right wasn't working. But it's not doing the job for me. While uncommenting lockscreen() does, I can live with the two scrollbars, see https://www.sturmundbraem.ch/referenzen#forschungsstiftung-strom-und-mobilkommunikation