Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading documentation / wrong implementation #9

Open
ed255 opened this issue Jul 9, 2021 · 0 comments
Open

Misleading documentation / wrong implementation #9

ed255 opened this issue Jul 9, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@ed255
Copy link
Contributor

ed255 commented Jul 9, 2021

// VerifyEIP1186 verifies the whole Ethereum proof obtained with eth_getProof
// method against a StateRoot. It verifies Account proof against StateRoot and
// all Storage proofs against StorageHash.
func VerifyEIP1186(proof *StorageProof) (bool, error) {
for _, sp := range proof.StorageProof {
sp := sp
if ok, err := VerifyEthStorageProof(&sp, proof.StorageHash); !ok {
return false, err
}
}
return true, nil
}

The documentation of this function states that it verifies the account proof but it does not!

@ed255 ed255 added the bug Something isn't working label Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant