From 1601f40172e5dedf1a655ad20fd3f02c130fe6ef Mon Sep 17 00:00:00 2001 From: tantm3 Date: Mon, 28 Aug 2023 20:57:28 +0700 Subject: [PATCH] fix: required argument and wait resources are deleted when uninstalling chart release --- charts/vmonitor-metric-agent/CHANGELOG.md | 6 ++++++ charts/vmonitor-metric-agent/Chart.yaml | 2 +- charts/vmonitor-metric-agent/README.md | 2 +- charts/vmonitor-metric-agent/templates/secret-vmonitor.yaml | 4 ++-- 4 files changed, 10 insertions(+), 4 deletions(-) create mode 100644 charts/vmonitor-metric-agent/CHANGELOG.md diff --git a/charts/vmonitor-metric-agent/CHANGELOG.md b/charts/vmonitor-metric-agent/CHANGELOG.md new file mode 100644 index 0000000..eef1fca --- /dev/null +++ b/charts/vmonitor-metric-agent/CHANGELOG.md @@ -0,0 +1,6 @@ +# vMonitor Platform Metric Agent changelog + +## 0.3.0 + +* Fix `clusterrole` not being removed when uninstalling chart release +* Fix `required argument` when upgrading chart release \ No newline at end of file diff --git a/charts/vmonitor-metric-agent/Chart.yaml b/charts/vmonitor-metric-agent/Chart.yaml index f1d6236..7c59cdf 100644 --- a/charts/vmonitor-metric-agent/Chart.yaml +++ b/charts/vmonitor-metric-agent/Chart.yaml @@ -15,5 +15,5 @@ dependencies: name: kube-state-metrics repository: https://prometheus-community.github.io/helm-charts version: 4.20.0 -version: 0.2.0 +version: 0.3.0 appVersion: "1.26.2" diff --git a/charts/vmonitor-metric-agent/README.md b/charts/vmonitor-metric-agent/README.md index 956d187..bb02508 100644 --- a/charts/vmonitor-metric-agent/README.md +++ b/charts/vmonitor-metric-agent/README.md @@ -61,7 +61,7 @@ kubectl get pod <-n your_namespace> | grep "vmonitor-metric-agent" To uninstall/delete the `vmonitor-metric-agent` deployment: ```bash -helm uninstall vmonitor-metric-agent +helm uninstall vmonitor-metric-agent --wait ``` The command removes all the Kubernetes resources associated with the chart and deletes the release. diff --git a/charts/vmonitor-metric-agent/templates/secret-vmonitor.yaml b/charts/vmonitor-metric-agent/templates/secret-vmonitor.yaml index 3306117..f6899e2 100644 --- a/charts/vmonitor-metric-agent/templates/secret-vmonitor.yaml +++ b/charts/vmonitor-metric-agent/templates/secret-vmonitor.yaml @@ -8,7 +8,7 @@ metadata: type: Opaque data: CLUSTER_NAME: {{ default "cluter-k8s" .Values.vmonitor.clusterName | b64enc | quote }} - IAM_CLIENT_ID: {{ required "IAM_CLIENT_ID is required value!" .Values.vmonitor.iamClientID | b64enc | quote }} - IAM_CLIENT_SECRET: {{ required "IAM_CLIENT_SECRET is required value!" .Values.vmonitor.iamClientSecret | b64enc | quote }} + IAM_CLIENT_ID: {{ default "YOUR_IAM_CLIENT_ID" .Values.vmonitor.iamClientID | b64enc | quote }} + IAM_CLIENT_SECRET: {{ default "YOUR_IAM_CLIENT_SECRET" .Values.vmonitor.iamClientSecret | b64enc | quote }} VMONITOR_SITE: {{ default "monitoring-agent.vngcloud.vn" .Values.vmonitor.vmonitorSite | b64enc | quote }} IAM_URL: {{ default "https://iamapis.vngcloud.vn/accounts-api/v2/auth/token" .Values.vmonitor.iamURL | b64enc | quote }} \ No newline at end of file