-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display the VCH Management API version on plugin summary page #586
Comments
@zjs, Do you mean the version of this api: https://10.193.25.225/ui/vic/rest/services/get-vic-appliances |
@zjs Is my understanding correct? @lweitzman , is this design ok? |
I'm not sure where that API sources its data from. If it's from the metadata on the VM, I worry that there are cases where it might be inaccurate. I think the safest way to get the API server version is from the API server itself (from the The code would be equivalent to this, but would call vic-ui/h5c/vic/src/vic-webapp/src/app/create-vch-wizard/create-vch-wizard.service.ts Lines 573 to 601 in 3a0295a
I suspect there's a simple refactoring that would avoid duplication between
Strictly speaking, this is the VCH Management API endpoint version. The VIC OVA (aka VIC Appliance) actually has a separate version number. |
Marking as need info: we need to confirm whether this is required for 1.4.3. |
fixed by:#598 |
As described in vmware/vic-product#1952, display the version of the VCH Management API the plugin is communicating with on the plugin's "summary" page, near where the plugin version is displayed.
As the user is not able to select which API server to use (#572), providing this information may greatly aid debugging when multiple versions of API servers are available.
The text was updated successfully, but these errors were encountered: