r/cluster: import does not include vmnic and vds

[pradeep17j]

Code of Conduct

• I have read and agree to the Code of Conduct.
• Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
• Do not leave "+1" or other comments that do not add relevant information or questions.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Terraform

v1.7.3

Terraform Provider

v0.10.0

VMware Cloud Foundation

5.2

Description

Import of a cluster resource does not return vmnic and vds information. If there is a existing cluster that needs to converted to a terraform managed resource, an import can be done and show can be used to extract the resource config file. If this resource does not have all the required fields for cluster operations, terraform plan and apply will not work

Affected Resources or Data Sources

r/vcf_cluster

Terraform Configuration

Output of terraform show:

https://gist.github.com/pradeep17j/f0d31382dd8791c9da0faab87ce36c6a

Debug Output

terraform.tfstate file after import:

https://gist.github.com/pradeep17j/9d5c926fa805260b825c37200afe6fd0

Panic Output

No response

Expected Behavior

Return all the required fields for a resource when performing an import operation.

Actual Behavior

The vds and vmnic information missing after an import operation.

Steps to Reproduce

Example:

terraform import vcf_cluster.clus2 "801b1c2f-33be-497b-bc28-04fc463fa40d"

801b1c2f-33be-497b-bc28-04fc463fa40d is the ID of the management domain default cluster.

Environment Details

No response

Screenshots

No response

References

No response

[pradeep17j]

The same issue happens with d/vcf_instance. It returns back empty vmnic and vds information.

Please fix also:

  data vcf_cluster {
  }

The output returned back from data vcf_instance { } is as below

  data "vcf_cluster" "cluster1" {
    cluster_id             = "801b1c2f-33be-497b-bc28-04fc463fa40d"
    domain_id              = "46ec313d-e782-4f46-b6c9-eb62e9b2b5d3"
    host                   = [
        {
            availability_zone_name = ""
            host_name              = "esxi-3.vrack.vsphere.local"
            id                     = "03d85265-48ce-48e4-af7e-fd4ac6bc5b27"
            ip_address             = "10.0.4.5"
            license_key            = ""
            password               = ""
            serial_number          = ""
            ssh_thumbprint         = ""
            username               = ""
            vmnic                  = []
        },
      ]
    id                     = "801b1c2f-33be-497b-bc28-04fc463fa40d"
    is_default             = true
    is_stretched           = false
    name                   = "sddcId-10011"
    primary_datastore_name = "sddc_mgmt_vsan"
    primary_datastore_type = "VSAN"
    vds                    = []
  }

[tenthirtyam]

@pradeep17j please use the markdown editor tools to apply content formatting.

[tenthirtyam]

The same issue happens with d/vcf_instance. It returns back empty vmnic and vds information.

Please fix also:

  data vcf_cluster {
  }

Hi @pradeep17j 👋 - Please open a seperate issue for this issue with d/vcf_instance.

Ryan Johnson
Distinguished Engineer, VMware by Broadcom

[tenthirtyam]

Hi @pradeep17j 👋 -

I have formatted the issue content and version updated to reflect supported and shipping versions that the provider supports.

We kindly ask that you do the same for future issues.

Ryan Johnson
Distinguished Engineer, VMware by Broadcom

[burnsjared0415]

will pick this up

[tenthirtyam]

Assigned to Jared Burns, VMware by Broadcom.

[burnsjared0415]

the problem is that the current code does not call the correct API to get vds configuration, the ImportCluster calls /v1/clusters, to get vds information you have to call /v1/clusters/{id}/vdses which is not in the code here

[github-actions]

'Marking this issue as stale due to inactivity. This helps us focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context.
Thank you!'