🐛 Update VM API spec.bootstrap.sysprep fields #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
feature/sysprep-api-fields
branch
from
27553ae to
27fac8c
Compare
akutz
changed the title
akutz
force-pushed
the
feature/sysprep-api-fields
branch
from
27fac8c to
a760586
Compare
akutz
changed the title
akutz
force-pushed
the
feature/sysprep-api-fields
branch
from
a760586 to
3e5bcbf
Compare
github-actions
bot
added
size/L
akutz
force-pushed
the
feature/sysprep-api-fields
branch
from
3e5bcbf to
b1c208e
Compare
dilyar85
approved these changes
Nov 1, 2024
akutz
force-pushed
the
feature/sysprep-api-fields
branch
from
b1c208e to
d4b806f
Compare
This patch includes several changes to the VirtualMachine API's sysprep bootstrap provider, including: * The field `spec.bootstrap.sysprep.userData` is now required. This is only true if `spec.bootstrap.sysprep` is set, so it does not prevent someone from omitting a bootstrap provider. This is aligned with the VMODL used by VM Operator to customize the guest. * The sysprep bootstrap provider now defaults to the UTC timezone by setting the default value of the field `spec.bootstrap.sysprep.guiUnattended.timeZone` to 85. This is because the VMODL says guiUnattended is required (https://dp-downloads.broadcom.com/api-content/apis/API_VWSA_001/8.0U3/html/ReferenceGuides/vim.vm.customization.Sysprep.html), but we got away with it being optional in VM Op since all the contained fields default to their primitive type defaults. Except timeZone defaulted to 0, which s GMT-12 per the reference (https://learn.microsoft.com/en-us/previous-versions/windows/embedded/ms912391(v=winembedded.11)), which is not a sane default, whereas UTC is.
akutz
force-pushed
the
feature/sysprep-api-fields
branch
from
d4b806f to
3eab5a0
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch includes several changes to the VirtualMachine API's sysprep/linuxprep bootstrap provider, including:
The field
spec.bootstrap.sysprep.userDatais now required. This is only true ifspec.bootstrap.sysprepis set, so it does not prevent someone from omitting a bootstrap provider. This is aligned with the VMODL used by VM Operator to customize the guest.The sysprep bootstrap provider now defaults to the UTC timezone by setting the default value of the field
spec.bootstrap.sysprep.guiUnattended.timeZoneto be 85. This is because the VMODL saysguiUnattendedis required, but we got away with it being optional in VM Op since all the contained fields default to their primitive type defaults. ExcepttimeZonedefaulted to0, which s GMT-12 per the reference, which is not a sane default, whereas UTC is.Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #790
Are there any special notes for your reviewer:
Please add a release note if necessary: