✨ Bring your own (encryption) key (BYOK) #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanv
reviewed
Aug 20, 2024
akutz
force-pushed
the
feature/vm-encryption-class-name
branch
from
ca728b9 to
878e150
Compare
akutz
force-pushed
the
feature/vm-encryption-class-name
branch
from
878e150 to
5e23bc7
Compare
github-actions
bot
added
size/XXL
akutz
force-pushed
the
feature/vm-encryption-class-name
branch
8 times, most recently
from
9660977 to
7e94b9c
Compare
akutz
force-pushed
the
feature/vm-encryption-class-name
branch
14 times, most recently
from
418e713 to
e68a64a
Compare
akutz
force-pushed
the
feature/vm-encryption-class-name
branch
6 times, most recently
from
daac980 to
f8b5845
Compare
akutz
force-pushed
the
feature/vm-encryption-class-name
branch
2 times, most recently
from
e143245 to
52597ae
Compare
aruneshpa
requested review from
aruneshpa
and removed request for
rtsanev-github
aruneshpa
reviewed
Sep 25, 2024
akutz
force-pushed
the
feature/vm-encryption-class-name
branch
2 times, most recently
from
7ef6391 to
42bc00f
Compare
dilyar85
reviewed
Sep 26, 2024
controllers/virtualmachine/virtualmachine/virtualmachine_controller.go
Outdated
Show resolved
Hide resolved
aruneshpa
reviewed
Sep 26, 2024
akutz
force-pushed
the
feature/vm-encryption-class-name
branch
5 times, most recently
from
4b991fd to
94aa037
Compare
aruneshpa
reviewed
Sep 27, 2024
This patch adds support for bringing your own encryption key used to encrypt/recrypt VMs.
akutz
force-pushed
the
feature/vm-encryption-class-name
branch
from
94aa037 to
00f5f8b
Compare
Minimum allowed line rate is |
|
@aruneshpa I have addressed all of your feedback on the PR. While I did not accept it all, and stated my reasons, unless you have a strong objection, I am going to merge this PR so it does not continue to grow. We can revisit your concerns post-merge if that is alright? |
Sounds good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch adds support for bringing your own encryption key used to encrypt/recrypt VMs.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
This PR will be rebased once #670 and #672 are merged.
Please add a release note if necessary:
📚 Documentation preview 📚: https://vm-operator--673.org.readthedocs.build/en/673/