Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary flush() call in TryToDecodeBase64Gzip function #224

Open
dilyar85 opened this issue Sep 18, 2023 · 1 comment
Open

Remove unnecessary flush() call in TryToDecodeBase64Gzip function #224

dilyar85 opened this issue Sep 18, 2023 · 1 comment

Comments

@dilyar85
Copy link
Member

Please describe the solution you would like.
In https://github.com/vmware-tanzu/vm-operator/blob/main/pkg/util/enc.go, the TryToDecodeBase64Gzip function currently has a flush() call before close(). This flush() call seems unnecessary because the close() method will call flush() as well, as stated in https://pkg.go.dev/compress/gzip#Writer.Close.

Is there anything else you would like to add?
There are some test specs that use hardcoded strings to test this function. These test specs will also need to be updated when implementing the above change.

Please tell us about your environment.
N/A.

@akutz
Copy link
Collaborator

akutz commented Dec 1, 2023

Just testing the new comment action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants