Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make note that Subnet/SubnetSet for SubnetPorts are exclusive #436

Open
ihgann opened this issue Dec 6, 2023 · 0 comments
Open

Make note that Subnet/SubnetSet for SubnetPorts are exclusive #436

ihgann opened this issue Dec 6, 2023 · 0 comments
Assignees

Comments

@ihgann
Copy link

ihgann commented Dec 6, 2023

Elaborating on a comment from @bryanv .

ref:

// SubnetPortSpec defines the desired state of SubnetPort.
type SubnetPortSpec struct {
// Subnet defines the parent Subnet name of the SubnetPort.
Subnet string `json:"subnet,omitempty"`
// SubnetSet defines the parent SubnetSet name of the SubnetPort.
SubnetSet string `json:"subnetSet,omitempty"`

Can we make comments indicating that Subnet and SubnetSet are exclusive for a SubnetPortSpec? That if you choose "Subnet", then "SubnetSet" may not also be selected - and what the expected failure case would be here. Additionally - is the failure handled by a ValidatingWebhook, or will the SubnetPort resolve incorrectly (ValidatingWebhook might be better to reject outright).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants