You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// SubnetPortSpec defines the desired state of SubnetPort.
typeSubnetPortSpecstruct {
// Subnet defines the parent Subnet name of the SubnetPort.
Subnetstring`json:"subnet,omitempty"`
// SubnetSet defines the parent SubnetSet name of the SubnetPort.
SubnetSetstring`json:"subnetSet,omitempty"`
Can we make comments indicating that Subnet and SubnetSet are exclusive for a SubnetPortSpec? That if you choose "Subnet", then "SubnetSet" may not also be selected - and what the expected failure case would be here. Additionally - is the failure handled by a ValidatingWebhook, or will the SubnetPort resolve incorrectly (ValidatingWebhook might be better to reject outright).
The text was updated successfully, but these errors were encountered:
Elaborating on a comment from @bryanv .
ref:
nsx-operator/pkg/apis/v1alpha1/subnetport_types.go
Lines 11 to 16 in 8cdf0a2
Can we make comments indicating that Subnet and SubnetSet are exclusive for a SubnetPortSpec? That if you choose "Subnet", then "SubnetSet" may not also be selected - and what the expected failure case would be here. Additionally - is the failure handled by a ValidatingWebhook, or will the SubnetPort resolve incorrectly (ValidatingWebhook might be better to reject outright).
The text was updated successfully, but these errors were encountered: