Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: The kinds filter is not working properly when it's used in searching resource. #210

Open
reasonerjt opened this issue Aug 9, 2021 · 1 comment · May be fixed by #211
Open

[BUG]: The kinds filter is not working properly when it's used in searching resource. #210

reasonerjt opened this issue Aug 9, 2021 · 1 comment · May be fixed by #211

Comments

@reasonerjt
Copy link
Contributor

If the filter has notapod in kinds, the pod resources will not be filtered.
https://github.com/vmware-tanzu/crash-diagnostics/blob/main/k8s/client.go#L149

if len(kinds) > 0 && !strings.Contains(kinds, strings.ToLower(res.Kind)) {
		continue
}

It should use sliceContains to handle the filter.
reasonerjt added a commit to reasonerjt/crash-diagnostics that referenced this issue Aug 9, 2021
@reasonerjt
Use sliceContains to filter the resources by kinds
b65815e 
fixes vmware-tanzu#210

Signed-off-by: Daniel Jiang <[email protected]>
This was referenced Aug 9, 2021
Draft
Merged
@vladimirvivien
Copy link
Contributor

@reasonerjt I just merged #207
Please it out to ensure that this bug is still a problem. If so, rebase your PR and we can get it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use sliceContains to filter the resources by kinds reasonerjt/crash-diagnostics
2 participants
@vladimirvivien @reasonerjt