Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yarn to Contributing: Development Dependencies #15

Open
waciumawanjohi opened this issue Mar 31, 2022 · 1 comment
Open

Add yarn to Contributing: Development Dependencies #15

waciumawanjohi opened this issue Mar 31, 2022 · 1 comment
Labels

Comments

@waciumawanjohi
Copy link
Contributor

Bug description:

Yarn not mentioned in dev dependencies.

Steps to reproduce:

Please provide a set of steps to reproduce the behavior (example):

  1. Run make lint

Expected behavior:

As a contributor, when I've installed the development dependencies, I should be able to run the make commands.

Actual behavior:

/Library/Developer/CommandLineTools/usr/bin/make -C site lint
yarn install
make[1]: yarn: No such file or directory
make[1]: *** [dev-dependencies] Error 1
make: *** [lint] Error 2
@squeedee
Copy link
Member

squeedee commented Mar 31, 2022

Can we block this on the site migration (#436), and add it to the site repo after the migration?

@martyspiewak martyspiewak transferred this issue from vmware-tanzu/cartographer Apr 11, 2022
@martyspiewak martyspiewak moved this from IPM to Todo in Cartographer OSS Apr 11, 2022
squeedee added a commit that referenced this issue Jun 19, 2022
@squeedee squeedee moved this from Todo to PR in Cartographer OSS Jun 20, 2022
@squeedee squeedee moved this from PR to Closed in Cartographer OSS Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

No branches or pull requests

3 participants
@squeedee @waciumawanjohi and others