Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI doesn't run lint #56

Closed
petewall opened this issue Aug 24, 2021 · 4 comments
Closed

CI doesn't run lint #56

petewall opened this issue Aug 24, 2021 · 4 comments

Comments

@petewall
Copy link
Contributor

No description provided.

@migmartri
Copy link
Contributor

migmartri commented Aug 24, 2021

It does run as github action https://github.com/vmware-tanzu/asset-relocation-tool-for-kubernetes/actions

Or do you mean that that's not even working? I can see the check being added to all my PRs

@migmartri
Copy link
Contributor

btw, the reason I decided to go with linting using github actions instead of our concourse CI is because

1 - GH action is the recommended approach and it's implementation is trivial
2 - They recommend running as an standalone pipeline. Github treats it as an additional check
3 - It's aligned with #25

@petewall
Copy link
Contributor Author

I finished this work (in PR #59) because it removes goimports and as long as we have the concourse ci running, I'd like to see it in both.

It's also useful exercise for me that I can take to my other go projects.

@petewall
Copy link
Contributor Author

This is done now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants