Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the implementation of factor is horrible #21

Open
kspalaiologos opened this issue Jul 10, 2021 · 1 comment
Open

the implementation of factor is horrible #21

kspalaiologos opened this issue Jul 10, 2021 · 1 comment

Comments

@kspalaiologos
Copy link

the current implementation of factor is laughably bad; consider using Floyd's cycle-finding algorithm with Brent's algorithms to somehow faciliate optimised Pollard's rho algorithm. It seems to be what coreutils do (+ trial division i guess), except I can't be bothered to check what kind of cycle finding algorithm do they use, since the code is, as usual for GNU, obfuscated.

@spytheman
Copy link
Member

PRs are welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants