Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Image Cropping Functionality for thumbnails / Images #37

Open
silvanheller opened this issue Jul 24, 2020 · 5 comments
Open

Comments

@silvanheller
Copy link
Member

silvanheller commented Jul 24, 2020

For some use cases, it would be nice to have the possibility to query for a subelement of a retrieved element, be that a thumbnail of a video or an image. This could be implemented for example by adding a cropping functionality to the QuickViewerComponent.

@silvanheller silvanheller changed the title Implement Image Cropping Functionality for thumbnails / Images [Wishlist] Implement Image Cropping Functionality for thumbnails / Images Jul 24, 2020
@silvanheller silvanheller changed the title [Wishlist] Implement Image Cropping Functionality for thumbnails / Images Implement Image Cropping Functionality for thumbnails / Images Aug 4, 2020
@silvanheller silvanheller added Good First Issue Good Issue for first-time contributors and removed Good First Issue Good Issue for first-time contributors labels Mar 19, 2021
@mittulmandhan
Copy link
Contributor

Can I work on this?

@lucaro
Copy link
Member

lucaro commented May 15, 2021

Of course, feel free to do so.

@mittulmandhan
Copy link
Contributor

mittulmandhan commented May 16, 2021

I can think of these 2 ways:
1.) On upload button(present in image query modal window) click, a stacked up modal window will open where you can upload and crop the image at the same time (Basically cropping while uploading).
2.) Once the image is uploaded, an edit button will appear right below the uploaded image in the image query modal window. Now user can click on the edit button which will then open crop options.

Please share your ideas too.
I can make mock sketches of the implemented UI if you are having difficulty visualizing it.

@lucaro
Copy link
Member

lucaro commented May 17, 2021

Stacked modals are probably not ideal. Why not add the feature to the sketch modal?

@mittulmandhan
Copy link
Contributor

mittulmandhan commented May 17, 2021

the second option does not require a stacked modal and crop feature can be added in the sketch modal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants