A couple endtoend cluster tests enhancement
#17247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
shlomi-noach
removed
NeedsDescriptionUpdate
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17247 +/- ##
==========================================
+ Coverage 67.39% 67.40% +0.01%
==========================================
Files 1570 1570
Lines 252917 252917
==========================================
+ Hits 170446 170490 +44
+ Misses 82471 82427 -44 ☔ View full report in Codecov by Sentry. |
shlomi-noach
removed
the
NeedsIssue
dbussink
changed the title
endtond cluster tests enhancementendtoend cluster tests enhancement
| @@ -72,7 +73,9 @@ func (vtctldclient *VtctldClientProcess) ExecuteCommandWithOutput(args ...string | |||
| filterDoubleDashArgs(pArgs, vtctldclient.VtctldClientMajorVersion)..., | |||
| ) | |||
| msg := binlogplayer.LimitString(strings.Join(tmpProcess.Args, " "), 256) // limit log line length | |||
| log.Infof("Executing vtctldclient with command: %v (attempt %d of %d)", msg, i+1, retries) | |||
| if !vtctldclient.Quiet { | |||
There was a problem hiding this comment.
Where is this set? Or is it for future use?
frouioui
reviewed
Nov 19, 2024
Comment on lines
+462
to
+463
| // MultiQueryTablet lets you execute a query in this tablet and get the result | ||
| func (vttablet *VttabletProcess) MultiQueryTablet(sql string, keyspace string, useDb bool) error { |
There was a problem hiding this comment.
Same here, this is not used yet. I am guessing there will be a follow-up PR to actually use it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two enhancements in
go/test/endtoend/cluster:VtctldClientProcesssupportsQuietmode, where it does not log the command line invocation to standard output. TheQuietfield is not thread safe.This will be useful to reduce log clutter. I especially intend to use it to reduce
CheckThrottlerlogs.VttabletProcesssupportsMultiQueryTablet(), complementingMultiQueryTabletWithDB(). This can be used to issue non-DB specific multi-query SQL from external source.Related Issue(s)
No issue for this PR.
Checklist
Deployment Notes