Refactor navbar #562
Merged
Refactor navbar #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad31 <[email protected]>
Signed-off-by: Jad31 <[email protected]>
frouioui
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
This is already planned for a follow-up PR already, but putting it out there so it is known: let's extra the Hero into its own component that we will re-use on every page, that will ensure the Hero is consistent everywhere and will make the codebase more maintainable.
|
Linked to #525 |
Signed-off-by: Jad31 <[email protected]>
Signed-off-by: Jad31 <[email protected]>
frouioui
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor the navbar to match the new figma design.
Fix responsive issues as well
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?