feat(html): add head when missing from entry point #784
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-plugin-pwa-legacy ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
userquin
commented
Nov 13, 2024
| console.warn([ | ||
| '', | ||
| yellow('PWA WARNING:'), | ||
| '</head> and <body> not found in the html, the service worker and web manifest will not be injected.', |
There was a problem hiding this comment.
replace this message with:
</head> and <body> not found in the html, the service worker and the web manifest may not be injected.
userquin
commented
Nov 15, 2024
| @@ -25,20 +26,36 @@ navigator.serviceWorker.register('${path}', { scope: '${options.scope}' }) | |||
| }`.replace(/\n/g, '') | |||
| } | |||
|
|
|||
| export function checkForHtmlHead(html: string) { | |||
| if (!html.includes('</head>')) { | |||
There was a problem hiding this comment.
should we also check for <head />? This will require to parse the html: Vite doesn't add the entries if head is missing and returning the tag array instead here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When there is no
headin the html entry point, the sw and the web manifest may not be register: this PR checks for</head>and<body>to add the head when required, showing a warning when missing both.Linked Issues
resolves #782
Additional Context
Tip
The author of this PR can publish a preview release by commenting
/publishbelow.