Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add working v0.1.0 version of Sube/libwallet for JS #37

Closed
wants to merge 4 commits into from
Closed

Add working v0.1.0 version of Sube/libwallet for JS #37

wants to merge 4 commits into from

Conversation

S0c5
Copy link
Member

@S0c5 S0c5 commented Jan 17, 2024

closes #35

@S0c5 S0c5 force-pushed the fix/working-version-sube branch from bdb9a3b to a68d59f Compare January 21, 2024 23:00
@S0c5 S0c5 requested review from pandres95 and olanod and removed request for pandres95 March 10, 2024 23:10
olanod
olanod requested changes Mar 12, 2024
View reviewed changes
Copy link
Member

@olanod olanod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's further break it down starting with the libwallet changes for example. I'd like to know why there's a need for Clone in the key pair, initially it was by design that private keys cannot be cloned as they shouldn't leak.

@S0c5
Copy link
Member Author

S0c5 commented Mar 24, 2024

Good Catch!

I removed the unnecessary Clones!

@S0c5 S0c5 closed this Apr 17, 2024
@olanod olanod deleted the fix/working-version-sube branch July 18, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olanod olanod olanod requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SubeX - JS bindings
2 participants
@S0c5 @olanod