Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtio-fs doesn't aware modified unless refresh #945

Open
fecet opened this issue Jul 26, 2023 · 8 comments
Open

virtio-fs doesn't aware modified unless refresh #945

fecet opened this issue Jul 26, 2023 · 8 comments

Comments

@fecet
Copy link

fecet commented Jul 26, 2023

Describe the bug

After modify file system on host, windows guest have to refresh to know that.

To Reproduce
Steps to reproduce the behaviour:

Write something on host

Expected behavior
A clear and concise description of what you expected to happen.

Changes happen on guest as soon as host

Screenshots
image

Host:

  • Disto: Ubuntu
  • Kernel version: 5.0.4
  • QEMU version 7.0
  • QEMU command line start by virt-manager
  • libvirt version 8.6
  • libvirt XML file

VM:

  • Windows 10
  • virtiofs
  • 1.229

Additional context
Add any other context about the problem here.

@viktor-prutyanov
Copy link
Collaborator

Hi @fecet,

Windows Explorer shows a state as of the most recent ReadDirectory return. But any new request to FS will work with an updated state.

From an architectural point of view, Explorer can show an updated state with ReadDirectoryChangesW, but in the virtiofs service it requires a processing of the notify VirtIO queue. Also I'm not sure that WinFsp has full support of such FS to kernel notify logic.

To sum up, this is hypothetically feasible, but requires a lot of investigation and development. I'm not sure this is a good investment of time for just seeing host updates in Explorer.

@fecet
Copy link
Author

fecet commented Jul 26, 2023

of course we dont care Explorer but for some reason I need to modify file on host and watch the changes in guest. Maybe watching file soulds like a interesting feature good to consider.

My current solution is share smb from guest, it's really slow

@viktor-prutyanov
Copy link
Collaborator

All changes are seen on the guest side

@viktor-prutyanov
Copy link
Collaborator

Explorer simply doesn't show them

@fecet fecet closed this as completed Jul 26, 2023
@fecet
Copy link
Author

fecet commented Jul 26, 2023

So it's perhaps beeter to be a FR, add watching file support for guest

@viktor-prutyanov
Copy link
Collaborator

OK, so let's reopen it and mark it as a feature request.

@xiagao
Copy link

xiagao commented Dec 4, 2024

@xiagao
Copy link

xiagao commented Dec 4, 2024

@YanVugenfirer I have no privilege to add label, could you update with 'Jira_Attached' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants