LBA endian error for SCSIOP_{READ,WRITE}6

[chrehrhardt]

In viostor/virtio_stor_hw_helper.c:RhelGetLba() the case for 6-byte operations looks like this:

        EIGHT_BYTE lba;
        [...]
        case SCSIOP_READ6:
        case SCSIOP_WRITE6: {
            lba.Byte0 = Cdb->CDB6READWRITE.LogicalBlockMsb1;
            lba.Byte1 = Cdb->CDB6READWRITE.LogicalBlockMsb0;
            lba.Byte2 = Cdb->CDB6READWRITE.LogicalBlockLsb;

From reading the code and the other cases it very much looks as if this gets the endianness wrong.
The LSB should go into Byte0 not the MSB.

As this does not seem to cause issues in real life, I'd assume that Windows does not uses these SCSI opcodes.

[vrozenfe]

Windows does support 6-byte CDBs, but viostor doesn't.
viostor StartIo routine completes 6-byte CDBs as SRB_STATUS_INVALID_REQUEST

Do you have any particular reason for sending SCSIOP_READ6/SCSIOP_WRITE6 requests
to viostor miniport?

Best,
Vadim

[chrehrhardt]

No, I was just reading code because I'm trying to do something similar. And the code looks more or less obviously wrong, so I thought I'd let you know. I didn't realize that the code is in fact unreachable.

[vrozenfe]

This piece of code is quite old, Definitely needs to be cleaned up.
Thank you for catching that.
Vadim.

[YanVugenfirer]

Reviewed.