Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

viostor: It seems that RhelScsiVerify has an improperly handled boundary condition. #1095

Closed
zjmletang opened this issue May 9, 2024 · 5 comments
Closed

viostor: It seems that RhelScsiVerify has an improperly handled boundary condition. #1095

zjmletang opened this issue May 9, 2024 · 5 comments
Assignees
@YanVugenfirer @vrozenfe
Labels
Bug Bug viostor

Comments

@zjmletang
Copy link
Contributor

Describe the bug
In the RhelScsiVerify function, I understand that the case where lba + blocks == adaptExt->lastLBA should be a normal SRB. As shown in the figure below. If I am mistaken, please point it out to me.

image
@zjmletang zjmletang added the Bug Bug label May 9, 2024
@vrozenfe
Copy link
Collaborator

vrozenfe commented May 9, 2024

Right, we probably missed this case when applied 67f64d0

Thank you for spotting it out.
The fix is welcome.
Vadim.

@MaxXor
Copy link

MaxXor commented May 9, 2024

Other location I found it seems to be correct:

kvm-guest-drivers-windows/viostor/virtio_stor.c

Line 1333 in 657ad7e

if ((lba + blocks) > adaptExt->lastLBA) {

@zjmletang
Copy link
Contributor Author

Right, we probably missed this case when applied 67f64d0

Thank you for spotting it out. The fix is welcome. Vadim.
@vrozenfe
ok, I submit a patch to fix it
JianMing

zjmletang added a commit to zjmletang/kvm-guest-drivers-windows that referenced this issue May 10, 2024
@zjmletang
[viostor] fix incorrect IO boundary handling in RhelScsiVerify
57665b3 
Signed-off-by: Zhang JianMing [email protected]

for the problem description
please visit virtio-win#1095
@zjmletang zjmletang mentioned this issue May 10, 2024
Merged
YanVugenfirer pushed a commit that referenced this issue May 27, 2024
@zjmletang @YanVugenfirer
[viostor] fix incorrect IO boundary handling in RhelScsiVerify
4a38831 
Signed-off-by: Zhang JianMing [email protected]

for the problem description
please visit #1095
@jumbi77
Copy link

jumbi77 commented Jun 12, 2024

Quess this can be closed with 4a38831

@zjmletang
Copy link
Contributor Author

yes, it can be closed

MartinDrab pushed a commit to MartinDrab/kvm-guest-drivers-windows that referenced this issue Jul 9, 2024
@zjmletang
[viostor] fix incorrect IO boundary handling in RhelScsiVerify
8192322 
Signed-off-by: Zhang JianMing [email protected]

for the problem description
please visit virtio-win#1095
MartinDrab pushed a commit to MartinDrab/kvm-guest-drivers-windows that referenced this issue Aug 18, 2024
@zjmletang
[viostor] fix incorrect IO boundary handling in RhelScsiVerify
59e63ed 
Signed-off-by: Zhang JianMing [email protected]

for the problem description
please visit virtio-win#1095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YanVugenfirer YanVugenfirer

@vrozenfe vrozenfe

Labels
Bug Bug viostor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@YanVugenfirer @vrozenfe @MaxXor @jumbi77 @zjmletang