From 8ca437be9e2b6fedfb6664cd489b3172438fcbeb Mon Sep 17 00:00:00 2001 From: Eirik Stanghelle Morland Date: Tue, 10 Sep 2024 20:07:18 +0200 Subject: [PATCH] Require 3.x of process factory (#47) --- .github/workflows/test.yml | 4 ---- composer.json | 3 +-- src/ProcessFactory.php | 4 ++-- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 6f9cc66..76467a0 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -48,10 +48,6 @@ jobs: - name: Install dependencies run: composer --verbose install - - name: Run phpstan - if: matrix.php-version != 7.0 - run: composer phpstan - - name: Run tests run: composer test env: diff --git a/composer.json b/composer.json index cdd5363..96912c2 100644 --- a/composer.json +++ b/composer.json @@ -19,8 +19,7 @@ } }, "require": { - "symfony/process": "^4.0 || ^5.4", - "violinist-dev/process-factory": "^2.0", + "violinist-dev/process-factory": "^3.0", "violinist-dev/composer-lock-data": "^1.0" }, "scripts": { diff --git a/src/ProcessFactory.php b/src/ProcessFactory.php index 8448570..80215d2 100644 --- a/src/ProcessFactory.php +++ b/src/ProcessFactory.php @@ -10,8 +10,8 @@ class ProcessFactory implements ProcessFactoryInterface /** * {@inheritdoc} */ - public function getProcess(array $commandline, $cwd = null, array $env = null, $input = null, $timeout = 60, array $options = null) + public function getProcess(array $command, ?string $cwd = null, ?array $env = null, $input = null, ?float $timeout = 60) { - return new Process($commandline, $cwd, $env, $input, $timeout); + return new Process($command, $cwd, $env, $input, $timeout); } }