Backport to v11 vitessio#8634 reset table size stats when a table is …

…dropped schema engine: reset table size stats when a table is dropped Signed-off-by: deepthi <[email protected]> Signed-off-by: Vilius Okockis <[email protected]>
vinted · Apr 13, 2023 · 862e317 · 862e317
1 parent 8a1032b
commit 862e317
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/go/vt/vttablet/tabletserver/schema/engine.go b/go/vt/vttablet/tabletserver/schema/engine.go
@@ -382,6 +382,10 @@ func (se *Engine) reload(ctx context.Context) error {
 		if !curTables[tableName] {
 			dropped = append(dropped, tableName)
 			delete(se.tables, tableName)
+			// We can't actually delete the label from the stats, but we can set it to 0.
+			// Many monitoring tools will drop zero-valued metrics.
+			se.tableFileSizeGauge.Reset(tableName)
+			se.tableAllocatedSizeGauge.Reset(tableName)
 		}
 	}
 

diff --git a/go/vt/vttablet/tabletserver/schema/engine_test.go b/go/vt/vttablet/tabletserver/schema/engine_test.go
@@ -199,6 +199,8 @@ func TestOpenAndReload(t *testing.T) {
 	}
 	delete(want, "msg")
 	assert.Equal(t, want, se.GetSchema())
+	assert.Equal(t, int64(0), se.tableAllocatedSizeGauge.Counts()["msg"])
+	assert.Equal(t, int64(0), se.tableFileSizeGauge.Counts()["msg"])
 
 	//ReloadAt tests
 	pos1, err := mysql.DecodePosition("MariaDB/0-41983-20")