Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Ambiguous docs on re-using TLS sessions #32

Closed
duijf opened this issue Feb 19, 2018 · 0 comments
Closed

Ambiguous docs on re-using TLS sessions #32

duijf opened this issue Feb 19, 2018 · 0 comments

Comments

@duijf
Copy link

duijf commented Feb 19, 2018

Hello! I'm trying to implement TLS session re-use in one of our open source projects (channable/vaultenv#37), but am having a few issues understanding the current status of support from this library.

The docs for settingDisableSession currently read "Disable session management. TLS/SSL connections will always re-established their context. Not Implemented Yet."

To me, it seems like it would mean "Disabling session management isn't implemented, sessions will always be re-used", but this code suggests that the actual re-use isn't implemented (since the default of the tls package is noSessionManager).

Because of the double negative in the docs, the wording is a bit ambiguous.

Questions:

  • What is the best way to currently get TLS session re-use using hs-connection? Could we just override the default settings to use connectionSessionManager from this package? Or does it have problems and do we need to use another implementation (such as https://hackage.haskell.org/package/tls-session-manager-0.0.0.2/docs/Network-TLS-SessionManager.html or roll our own?)
  • Are you open to a PR which updates the docs with a pointer to an alternative implementation or rephrases the current wording to be more clear?

Thanks for your work you put in this package, by the way 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants