Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add critical cases to the JSON test file #97

Closed
vincentarelbundock opened this issue Jan 2, 2017 · 7 comments
Closed

Add critical cases to the JSON test file #97

vincentarelbundock opened this issue Jan 2, 2017 · 7 comments

Comments

@vincentarelbundock
Copy link
Owner

373a2fd

@cjyetman
Copy link
Collaborator

cjyetman commented Jan 9, 2017

the JSON file to add country name variations is here: tests/testthat/country_name_known_variations.json

Note that this file should only have unambiguous country name variations. For example, this file should not include "Korea" as a variation for "South Korea" because that could also be interpreted as "North Korea".

@vincentarelbundock
Copy link
Owner Author

For reference, this is probably going to remain open as this should be an ongoing process.

@vincentarelbundock
Copy link
Owner Author

vincentarelbundock commented Feb 8, 2017

  • Germany East
  • Germany West
  • Korea North

@cjyetman
Copy link
Collaborator

cjyetman commented Feb 15, 2017

  • "Virgin Islands (U.S.)" for "Virgin Islands, U.S."

@cjyetman
Copy link
Collaborator

  1. Is this test broken now that the default country names have possibly changed since the switch to CLDR names?
  2. This is technically only testing English names, correct? Maybe that should be very explicit so we know that we are not testing variations in other languages that we support (only German at the moment).

@vincentarelbundock
Copy link
Owner Author

I fixed all the tests for clrd already.

Being explicit is always good...

@vincentarelbundock
Copy link
Owner Author

#234

#233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants