New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resulting zip has missing executable permission #21

Open

abulka opened this issue Oct 30, 2022 · 1 comment

abulka commented Oct 30, 2022

Seems that executables get stripped of their +x flag when using this action. Permissions should be preserved.

Original files:

# ls -l build/linux/x64/release/bundle/
total 36
-rwxr-xr-x 1 root root 24480 Oct 30 04:51 ai_images_manager     <---- executable
drwxr-xr-x 3 root root  4096 Oct 30 04:51 data
drwxr-xr-x 3 root root  4096 Oct 30 04:51 images-icons
drwxr-xr-x 2 root root  4096 Oct 30 04:51 lib

  - name: Archive Release 
    uses: vimtor/action-zip@v1
    with:
      files: build/linux/x64/release/bundle/ README.md
      dest: MyApp-${{github.ref_name}}-linux.zip

When I unzip the resulting zip, the executable is missing the x permission and cannot be executed.

-rw-r--r-- 1 root root    2850 Oct 30 04:51 README.md
-rw-r--r-- 1 root root   24480 Oct 30 04:51 ai_images_manager   <--- missing +x
drwxr-xr-x 3 root root    4096 Oct 30 04:51 data
drwxr-xr-x 2 root root    4096 Oct 30 04:51 lib

By contrast, regular linux zip and e.g. a competing zip action https://github.com/TheDoctor0/zip-release preserve the +x permission.

The text was updated successfully, but these errors were encountered:

IohannRabeson commented Feb 17, 2023 •

edited

Loading

I reproduce this issue on MacOS as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment