Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "let" and "let var" became NODE_EXCMD #138

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix "let" and "let var" became NODE_EXCMD #138

wants to merge 5 commits into from

Conversation

tyru
Copy link
Member

@tyru tyru commented Aug 2, 2019

Fix #117

This branch is based on #136.
Please review this after #136.

@tyru tyru requested a review from blueyed August 2, 2019 11:44
@tyru
Copy link
Member Author

tyru commented Aug 6, 2019

@blueyed this is ready to review.

@tyru tyru requested a review from mattn August 7, 2019 08:37
@tyru tyru added the bug label Mar 6, 2020
@mattn
Copy link
Member

mattn commented Jan 15, 2022

Sorry about delay. Could you please fix conflicts?

@lehmacdj
Copy link
Contributor

While working on #190 I figured out that this PR and #117 which it fixes should both be closed because the issue's desired behavior is already implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueyed blueyed Awaiting requested review from blueyed

@mattn mattn Awaiting requested review from mattn

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

:let is parsed as NODE_EXCMD (not NODE_LET)
3 participants
@tyru @mattn @lehmacdj