Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darkmode #651

Closed
maxdnet opened this issue Apr 13, 2024 Discussed in #466 · 4 comments · Fixed by #895
Closed

Darkmode #651

maxdnet opened this issue Apr 13, 2024 Discussed in #466 · 4 comments · Fixed by #895

Comments

@maxdnet
Copy link

maxdnet commented Apr 13, 2024

Discussed in #466

Originally posted by ecospecifier December 12, 2023
With bootstrap 5.3 will we see Blazor Bootstrap embrace darkmode firstclass? I notce a lot of components like eg. toasts don't respect the darkmode class on the body of the parent.

@sikora507
Copy link

sikora507 commented May 6, 2024

There is even a dark/light mode switch on blazorBootstrap docs site https://docs.blazorbootstrap.com/
Before the feature is implemented, can we know how this was done? It looks similar to how bootstrap 5.3 handles darkmode but the attribute name is slightly different:
image
How this is done with Blazor? When I tried to implement it myself using webassembly component to write to localstorage and use immediately invoked function expression to set the proper theme on page render, it works when I refresh the page, but when I navigate through links, the attribute keeps disappearing, and turns on the default light mode

@Lucasharskamp
Copy link
Contributor

Lucasharskamp commented May 7, 2024

I agree that this is a sorely needed feature, plus the necessary documentation to get it easily up and running in our projects. Would make life a lot easier.

@devtrix
Copy link

devtrix commented Aug 28, 2024

Any update on this?

@gvreddy04
Copy link
Contributor

gvreddy04 commented Aug 29, 2024

We are working on this. Please follow #707 for more updates.

@gvreddy04 gvreddy04 self-assigned this Sep 8, 2024
@gvreddy04 gvreddy04 added this to the 3.1.0 milestone Sep 30, 2024
gvreddy04 added a commit that referenced this issue Oct 1, 2024
@gvreddy04 gvreddy04 linked a pull request Oct 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants