-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connected gensets step 2: complete the UI/UX cleanup #1287
Comments
No, I think the generator runtime is like the odometer on a car, it should not be manipulable. One note to service interval: Some controllers have their own service interval counter with reset option, but I think it's fine that both systems provide that and it is up to the customer to decide which one to use. |
@philipptrenz , sorry, I wasn’t clear: I meant button to reset the service interval counter. Totally agree on the total runtime counter. Does our system already use the DSE runtime counter for its own counting? Or if not the DSE status (running/stopped) in order to when when the counter needs to count and when not? |
@mpvader As far as I know, it does not use the reported runtime of the genset, but I think it initially uses the readings when a genset is first found, which still causes the values to drift apart. |
I want to propose to streamline this issue with additional tasks:
|
I also have a stack of VRM issues related to generator, which El Niño asked to discuss next Wednesday with me and @ReinvdZee: |
Hey @philipptrenz ,
I went through those issues; finally - sorry for the delay. See my responses there - hope that helps! |
I've added a todo item for the clear error gui button currently implemented. The current implementation was originally added for FP but is outdated. It does not do anything on the genset (possibly only on very old genset firmware versions, according to @martinbosma). Newer gensets support clearing errors via Modbus. We should offer the option to clear errors remotely only when that is actually supported by the genset. |
I moved some of the tasks to separate issues to track them separately. |
Most of the bullet points are checked. As per the UI alignment, gui-v1 and v2 won't be in sync since we're not doing all changes to v1 anymore. And the other UI-related items are tracked in different issues. (see this one about VRM). Closing this issue. |
In v3.33 we are making, a few changes to improve the UI. Some things were left out to not delay releasing v3.33 any further.
This issue is to list the things we need to look into as a follow-up:
The text was updated successfully, but these errors were encountered: