3.1.3 dataset.data reload when doing push()

[aguegu]

Describe the bug

simplescreenrecorder-2022-03-09_11.05.49.mp4

As shown in the video, each data.push() action would trigger a full reload by the animation.

3.1.3 is related to #58 , I think the cause of this problem is the cloneDeep() of data array. So each update/render is a full reload in 3.1.3

To Reproduce

Put a reproduction link here based on this templates

• Template for Vue 3
• Template for Vue 2
• Template for Nuxt 2

Version of vue-chart-3

3.1.3

Version of Vue

• Vue 3
• Vue 2
• Nuxt 2
• Nuxt 3

[aguegu]

In 3.1.2, the animation only applied to the newly pushed data. And I think it is what to expect.

simplescreenrecorder-2022-03-09_11.07.52.mp4

[victorgarciaesgi]

I thanks for the report, looks like a rushed a little on this update. I will look at it. cloneDeep happens only if the size of the array haven't changed (Chart.js using Proxies too, I think that's was what causing the bug)

[victorgarciaesgi]

Do you reproduce it on the demo ? https://codesandbox.io/s/demo-vue-chart-3-ugynm?file=/src/App.vue

[aguegu]

To reproduce it is not hard. You may create a line chart with options

scales: {
    x: {
      type: 'time',
      display: false,
    },
    y: {
      title: {
        display: true,
        text: 'value',
      },
    },
  },

and push data point to it

datasets[0].data.push({ x: Date.now(), y: Math.random() });

within a setInterval() callback.

Hope it would help.

[GijsGoudzwaard]

I have the same issue with both a line chart and bar chart. I'm using vue-chart-3 3.1.4 and vue 3.2.31. For now downgrading to 3.0.9 fixes it (npm i [email protected])

[victorgarciaesgi]

Yeah, it seems like the fix I added broke the animations. I need to take a time but this week it's going to be hard

[victorgarciaesgi]

Guys I'm so sorry. I just found out that when using deep: true using watch in Vue 3, the oldValue and newValue will be the same....
That's what messed with all the animations and updates

[victorgarciaesgi]

Currently finding out a way to compare new and old values

[victorgarciaesgi]

Should be fixed in 3.1.5. Sorry again

[GijsGoudzwaard]

No worries, can confirm that this is fixed in 3.1.5