-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATA-3338-fix-stability-of-vision-capture-all-from-camera #4557
base: main
Are you sure you want to change the base?
DATA-3338-fix-stability-of-vision-capture-all-from-camera #4557
Conversation
33c6fab
to
501209a
Compare
24f1702
to
842ea82
Compare
842ea82
to
583a8e6
Compare
GetImages = "GetImages" | ||
nextPointCloud = "NextPointCloud" | ||
pointCloudMap = "PointCloudMap" | ||
captureAllFromCamera = "CaptureAllFromCamera" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added captureAllFromCamera
to binary methods
} | ||
|
||
// GetFileExt gets the file extension for a capture file. | ||
func GetFileExt(dataType v1.DataType, methodName string, parameters map[string]string) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -240,49 +240,6 @@ func getFileTimestampName() string { | |||
return time.Now().Format(time.RFC3339Nano) | |||
} | |||
|
|||
// TODO DATA-246: Implement this in some more robust, programmatic way. | |||
func getDataType(methodName string) v1.DataType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the viaonCaptureAllFromCamera added to the binary data list.
return true | ||
} | ||
|
||
for _, e := range terminalCaptureFileErrs { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/viamrobotics/rdk/pull/4557/files#diff-d4e29d2325615faf57196f0792e0f204e4a16c442bcc44924cfc35675321ba7aR25-R29
This ensures that we give up if the capture file is invalid.
(ctx context.Context, _ map[string]*anypb.Any) (interface{}, error)
to(ctx context.Context, _ map[string]*anypb.Any) (data.CaptureResult, error)
see data/collector_types.go for more infodata.NewTabularCaptureResult
to create tabular capture results.