-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VisitorBase::Clone
does not handle declaration replacement
#439
Comments
Hello @parth-07 @vgvassilev To solve this issue, you can modify the
This implementation uses a With this modification, you should be able to use |
@ro4i7, please stop commenting under every issue. Select one or two issues and work to solve them, then repeat. PS: Solving means submit a PR, get a successful review and a merged PR. |
Fixes vgvassilev#465, vgvassilev#441, vgvassilev#439. Partially resolves vgvassilev#429 and vgvassilev#606.
This patch request optimizes storing and restoring in the reverse mode of Clad and introduces TBR analysis to determine when variables should be stored. Fixes vgvassilev#465, vgvassilev#441, vgvassilev#439. Partially resolves vgvassilev#429 and vgvassilev#606.
This patch optimizes storing and restoring in the reverse mode of Clad and introduces TBR analysis to determine when variables should be stored. Fixes vgvassilev#465, vgvassilev#441, vgvassilev#439. Partially resolves vgvassilev#429 and vgvassilev#606.
This patch optimizes storing and restoring in the reverse mode of Clad and introduces TBR analysis to determine when variables should be stored. Fixes vgvassilev#465, vgvassilev#441, vgvassilev#439, vgvassilev#429. Partially resolves vgvassilev#606.
This patch optimizes storing and restoring in the reverse mode of Clad and introduces TBR analysis to determine when variables should be stored. Fixes vgvassilev#465, vgvassilev#441, vgvassilev#439, vgvassilev#429. Partially resolves vgvassilev#606.
This patch optimizes storing and restoring in the reverse mode of Clad and introduces TBR analysis to determine when variables should be stored. Fixes vgvassilev#465, vgvassilev#441, vgvassilev#439, vgvassilev#429. Partially resolves vgvassilev#606.
Fixed in #655. |
We often use the
VisitorBase::Clone
function in all theVisitor
classes to perform cloning of the original expression. This is mostly used for the cases where we do not need the derivative of primal expression, as in those cases, we useVisit(...)
function instead.VisitorBase::Clone
function does not handle declaration replacement, and can thus produce incorrect cloned expressions. In all theVisitor
classes, declaration replacement is being handled inVisitDeclRefExpr
. Therefore, currently, the only way to get correct cloned expression in all cases is usingVisit
function.The text was updated successfully, but these errors were encountered: