Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure renovatebot generates changesets as well #615

Open
4 tasks
mvgijssel opened this issue Dec 11, 2023 · 1 comment
Open
4 tasks

Ensure renovatebot generates changesets as well #615

mvgijssel opened this issue Dec 11, 2023 · 1 comment
Assignees

Comments

@mvgijssel
Copy link
Member

mvgijssel commented Dec 11, 2023

Running a command after renovate is done only works with a self-hosted Renovatebot https://docs.renovatebot.com/self-hosted-configuration/#allowpostupgradecommandtemplating.

TODO

  • Support passing an argument to bazel run //:release_manager.generate
  • filter out release manager files when checking a diff (for Bazel-diff, bazel-differ and files-changed)
  • Include bazel run //:release_manager.generate in the BuildBuddy "Release all targets" step
  • Enable global renovateapp
@mvgijssel mvgijssel self-assigned this Dec 11, 2023
@mvgijssel mvgijssel converted this from a draft issue Dec 11, 2023
@mvgijssel mvgijssel moved this from In Progress to Todo in rules_release Dec 23, 2023
@mvgijssel
Copy link
Member Author

With the new version of rules_pycross it might not be necessary anymore to run a custom Renovatebot! We just need to generate changesets if the "triggering user" if Renovatebot. What we can also do is always run bazel run //:release_manager.generate within the release step in the CI and pass in the title of the PR to be used as the changeset body!

@mvgijssel mvgijssel changed the title Ensure renovatebot generates updates as well Ensure renovatebot generates changesets as well Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant