Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Client support #43

Open
essnine opened this issue Sep 4, 2022 · 1 comment
Open

Async Client support #43

essnine opened this issue Sep 4, 2022 · 1 comment

Comments

@essnine
Copy link

essnine commented Sep 4, 2022

Hi! I've been using this package for a bit, and for performance reasons I've had to create a modified TwirpClient that makes http requests using aiohttp instead of requests, so that ASGI apps can use the clients to make calls in a non-blocking way. Would you be open to adding such a class if a PR was raised?

@chadawagner
Copy link
Contributor

Hi @essnine - I forgot to look at open issues first, but opened this PR earlier this week. Since it seems you've also been thinking about this, please let me know if you have any feedback or suggestions for improvement. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants