-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mfe): support MFE config v2 #9471
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
chris-olszewski
force-pushed
the
olszewski/feat_mfe_v2_config
branch
from
December 3, 2024 21:05
cf71188
to
6db49a6
Compare
chris-olszewski
changed the title
feat(mfe): Support MFE config v2
feat(mfe): support MFE config v2
Dec 3, 2024
chris-olszewski
force-pushed
the
olszewski/feat_mfe_v2_config
branch
from
December 3, 2024 21:17
6db49a6
to
18f976f
Compare
tknickman
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for MFE v2 configuration to
turbo
along with supporting multiple default configuration file names.A few highlights of this PR:
turbo
so it can be unit testedMicrofrontends
Reviewing each commit individually should be helpful as I did code moves to ensure that we follow
Microfrontends
as the casing scheme throughout the code.Testing Instructions
Added unit tests for configuration loading.
Manual test in a MFE v2 enabled monorepo.