Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mfe): support MFE config v2 #9471

Merged
merged 14 commits into from
Dec 4, 2024
Merged

Conversation

chris-olszewski
Copy link
Member

@chris-olszewski chris-olszewski commented Nov 20, 2024

Description

Add support for MFE v2 configuration to turbo along with supporting multiple default configuration file names.

A few highlights of this PR:

  • Generalize MFE config interface to support multiple schemas
  • Add support for MFE v2 schema
  • Refactor MFE configuration loading by turbo so it can be unit tested
  • Rename of any casing permutation to Microfrontends

Reviewing each commit individually should be helpful as I did code moves to ensure that we follow Microfrontends as the casing scheme throughout the code.

Testing Instructions

Added unit tests for configuration loading.

Manual test in a MFE v2 enabled monorepo.

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 9:17pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 9:17pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 9:17pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 9:17pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 9:17pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 9:17pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 9:17pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 9:17pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 9:17pm

@chris-olszewski chris-olszewski force-pushed the olszewski/feat_mfe_v2_config branch from cf71188 to 6db49a6 Compare December 3, 2024 21:05
@chris-olszewski chris-olszewski changed the title feat(mfe): Support MFE config v2 feat(mfe): support MFE config v2 Dec 3, 2024
@chris-olszewski chris-olszewski merged commit 4a788d9 into main Dec 4, 2024
45 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/feat_mfe_v2_config branch December 4, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants