Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment): make bootstrap architecture-aware #261

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

thomas-fossati
Copy link
Contributor

The Ubuntu bootstrap script assumes x86 as the target architecture. When running on Arm, the installation of the step CLI package breaks.

Copy link
Collaborator

@setrofim setrofim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo the DCO issue

The Ubuntu bootstrap script assumes x86 as the target architecture.  When running on Arm, the installation of the step CLI package breaks.

Signed-off-by: Thomas Fossati <[email protected]>
@thomas-fossati thomas-fossati force-pushed the ubuntu-bootstrap-with-arch branch from f40ce72 to 5dadf35 Compare August 27, 2024 08:18
@thomas-fossati
Copy link
Contributor Author

LGTM, modulo the DCO issue

oops, I hadn't noticed that. Fixed now.

@thomas-fossati thomas-fossati merged commit 888a28f into main Aug 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants