Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: KVStore improvements: JSON in & out, without exceptions #87

Open
yogeshbdeshpande opened this issue Nov 18, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@yogeshbdeshpande
Copy link
Collaborator

Original issue reported by @thomas-fossati , as below:

Extracted from veraison/veraison#135:

I am tempted to always have valid JSON in and out of the kvstore. The present exception being the Get interface, which returns a Golang array of JSON objects. It could return a JSON array of all the Added objects instead.

@setrofim
Copy link
Collaborator

Is this something that we still actually want? KVStore interface is based on strings, not JSON. Currently Get() returns a slice of strings, not necessarily JSON objects. And, if I understand this correctly, this suggests it should return a single string encoding a JSON array? This would only complicate things for the user, requiring them to always perform the decoding of the array before they can do anything with the value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants