Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: Updated Supported MacOS versions #891

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Maintenance: Updated Supported MacOS versions #891

wants to merge 7 commits into from
+83 −36

Conversation

BenjamenMeyer
Copy link
Member

Code Changes:

@BenjamenMeyer BenjamenMeyer added this to the 0.10.x milestone Oct 5, 2024
@BenjamenMeyer BenjamenMeyer requested review from royfalk, Loki1950 and a team October 5, 2024 16:50
@BenjamenMeyer BenjamenMeyer self-assigned this Oct 5, 2024
royfalk
royfalk approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@royfalk royfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even support ARM architecture? I have an M1 I can try and test on, though it might take me a while to do it.

@BenjamenMeyer
Copy link
Member Author

Do we even support ARM architecture? I have an M1 I can try and test on, though it might take me a while to do it.

We haven't setup runners to try. But all new Mac's will be ARM-based so it's be good to find out

@BenjamenMeyer BenjamenMeyer mentioned this pull request Dec 11, 2024
Open
@BenjamenMeyer
Refactor MacOS CI Builds
336a86e 
- move the bootstrapping of MacOS into a script so it's easier to
  see what is going on and customize it for the various MacOS
  releases
@BenjamenMeyer
Checkout code before relying on what's in the repo
030e60c
@BenjamenMeyer
Bash via env bash
fcb2822
@BenjamenMeyer
proper OS matching
40dbdea
@royfalk
Copy link
Contributor

royfalk commented Dec 11, 2024

Two comments:

  1. We need to deprecate version 12. It's EoL.
  2. M1 was released in 2020. Officially supporting Mac Intel is a waste of time.
  3. Until Unless we can test on Apple silicon and check the game runs, there's no point in supporting a mac port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royfalk royfalk royfalk approved these changes

@Loki1950 Loki1950 Awaiting requested review from Loki1950

Assignees

@BenjamenMeyer BenjamenMeyer

Labels
CI/CD
Projects
None yet
Milestone
0.10.x
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjamenMeyer @royfalk