Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lib Component - Improvements to Resource #852

Merged
merged 13 commits into from
May 3, 2024

Conversation

royfalk
Copy link
Contributor

@royfalk royfalk commented Apr 30, 2024

This is part of the lib component PRs.
Various bug fixes and additions to Resource class.
Add unit tests

Please answer the following:

Code Changes:

Issues:

  • Loaded game had the ship constantly flying to the right.

@royfalk royfalk self-assigned this Apr 30, 2024
@stephengtuggy
Copy link
Contributor

Um, the issue with the ship constantly flying to the right sounds like a big deal to me. Can we get that fixed before we merge this?

I'm very glad you are adding more unit tests. We could certainly use more of those.

@royfalk
Copy link
Contributor Author

royfalk commented May 2, 2024

Um, the issue with the ship constantly flying to the right sounds like a big deal to me. Can we get that fixed before we merge this?
I've seen this bug before. That's definitely not something related to the Resource class. The save game in general is buggy as hell. When you load a game from another game, you don't find yourself in dock but in space. This will need a real deep dive into the system.

From the looks of it, it's now failing with:
Could NOT find Python3 (missing: Python3_INCLUDE_DIRS Python3_LIBRARIES.
in Rocky Linux 8.7.
Can I merge?

@stephengtuggy
Copy link
Contributor

Um, the issue with the ship constantly flying to the right sounds like a big deal to me. Can we get that fixed before we merge this?
I've seen this bug before. That's definitely not something related to the Resource class. The save game in general is buggy as hell. When you load a game from another game, you don't find yourself in dock but in space. This will need a real deep dive into the system.

From the looks of it, it's now failing with: Could NOT find Python3 (missing: Python3_INCLUDE_DIRS Python3_LIBRARIES. in Rocky Linux 8.7. Can I merge?

The Rocky Linux 8.7 failure is not a blocker. Our code in general doesn't build on Rocky Linux 8.x anymore We're not going to support it any longer.

I would like to play test this a little bit before we merge, if you don't mind.

@royfalk
Copy link
Contributor Author

royfalk commented May 2, 2024

I would like to play test this a little bit before we merge, if you don't mind.
Be my guest.

Copy link
Contributor

@stephengtuggy stephengtuggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Play testing went fairly well also. I did not encounter the issue with the ship constantly flying to the right. Maybe it doesn't occur on Windows? Or with a joystick?

At any rate, I am satisfied that we can go ahead and merge this PR.

@stephengtuggy
Copy link
Contributor

The one issue I did encounter was with the autopilot overshooting my destination, a medical station -- over and over and over. I don't think that's a new issue, but it might be. We'll probably want to troubleshoot that later.

@royfalk royfalk merged commit 893bc91 into vegastrike:master May 3, 2024
30 of 31 checks passed
@royfalk royfalk deleted the task_resource_better branch May 3, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants