-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lib Component - Improvements to Resource #852
Conversation
closes vegastrike#751 Also add tests and a few additional methods to store.
Add unit tests
Um, the issue with the ship constantly flying to the right sounds like a big deal to me. Can we get that fixed before we merge this? I'm very glad you are adding more unit tests. We could certainly use more of those. |
also reduce actual value.
From the looks of it, it's now failing with: |
The Rocky Linux 8.7 failure is not a blocker. Our code in general doesn't build on Rocky Linux 8.x anymore We're not going to support it any longer. I would like to play test this a little bit before we merge, if you don't mind. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Play testing went fairly well also. I did not encounter the issue with the ship constantly flying to the right. Maybe it doesn't occur on Windows? Or with a joystick?
At any rate, I am satisfied that we can go ahead and merge this PR.
The one issue I did encounter was with the autopilot overshooting my destination, a medical station -- over and over and over. I don't think that's a new issue, but it might be. We'll probably want to troubleshoot that later. |
This is part of the lib component PRs.
Various bug fixes and additions to Resource class.
Add unit tests
Please answer the following:
Code Changes:
Issues: