Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech debt]: remove skip opening auction #10976

Open
2 tasks
gordsport opened this issue Mar 22, 2024 · 0 comments
Open
2 tasks

[Tech debt]: remove skip opening auction #10976

gordsport opened this issue Mar 22, 2024 · 0 comments
Assignees
Milestone

Comments

@gordsport
Copy link
Contributor

Remove skip opening auction:

This code was originally added for unit testing, back when we had liquidity auctions still (not having to faff around setting up supplied stake, ensuring volume on either side of the book etc... in order to test stuff).

That code path was never meant to be executed when running normally, but clearly it's caused, or contributed to this issue.

  • remove the skip opening auction code
  • make sure all tests are passing
@gordsport gordsport added this to the 🕌 Genbu Temple milestone Mar 22, 2024
@vega-issues vega-issues moved this to Waiting Review in Core Kanban Mar 23, 2024
@vega-issues vega-issues moved this from Waiting Review to Approved in Core Kanban Mar 23, 2024
@github-project-automation github-project-automation bot moved this from Approved to Merged in Core Kanban Mar 23, 2024
@EVODelavega EVODelavega reopened this Mar 23, 2024
@gordsport gordsport moved this from Merged to Todo in Core Kanban Mar 23, 2024
@ze97286 ze97286 self-assigned this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants