-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy different versions of the editor #325
Comments
Do we have any lead on how to proceed with this? |
I don't think we want multiple versions of the editor. Instead, it would be nice if be able to choose the Vega and Vega-Lite versions dynamically, no? |
That would be better UX. If it is not much more work, we should do it. I just mention vega editor versions as it's a workaround if the ideal UX is too much work. |
I think it's easier to support multiple versions of Vega than it is to figure out which version of the editor corresponds to a particular Vega version. |
For sure! I've run binary search manually several times today to find the right version to revert to. 😐 |
Wait, if you need to check vega versions, then you did binary search with a locally deployed editor, right? |
Yes, by checking out tags |
Why? You can just link to Vega and Vega-Lite and use the version you want that way, no? |
Well, it's the same thing if I want to find the newest version that doesn't break to revert to. Still have to do binary search and re-build multiple times. Running yarn to install the version is actually faster. |
I see. Either way, the use case is switching Vega and Vega-Lite versions so I think we should try to automatically load these libraries from jsdelivr (maybe based on the version in the schema?). That doesn't seem too hard and is easy to use. |
Instead, let's do #336 |
e.g., https://vega.github.io/editor/0.28/
or https://vega.github.io/editor-archive/0.28/
This would be extremely useful for trying a spec with multiple versions to isolate bugs.
The text was updated successfully, but these errors were encountered: