Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs site routing and improve GH-pages deployment #128

Open
cjcenizal opened this issue Oct 26, 2023 · 0 comments
Open

Fix docs site routing and improve GH-pages deployment #128

cjcenizal opened this issue Oct 26, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@cjcenizal
Copy link
Contributor

We should essentially follow the steps here: https://create-react-app.dev/docs/deployment/#github-pages

Currently, loading a docs deep-link results in a 404, e.g. https://vectara.github.io/vectara-ui/summary. This is because of this issue: https://create-react-app.dev/docs/deployment/#notes-on-client-side-routing. This link proposes solving this issue:

Alternatively, you can use a trick to teach GitHub Pages to handle 404s by redirecting to your index.html page with a custom redirect parameter. You would need to add a 404.html file with the redirection code to the build folder before deploying your project, and you’ll need to add code handling the redirect parameter to index.html. You can find a detailed explanation of this technique in this guide.

@cjcenizal cjcenizal added the bug Something isn't working label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant