Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility for VuiPopover #124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

3eif
Copy link
Contributor

@3eif 3eif commented Sep 20, 2023

This PR adds move specificity for the screen reader for the Popover component. This also carries over to the SearchSelect component which uses Popover.

I was not able to get the screen reader to read out the number of items in the Popover like the Select component though. I think this is something that could be done outside of VUI instead where we do something like this:

        <VuiOptionsList
          isSelectable
          isScrollable
          onSelectOption={(value: string) => {
            setIsOpen(false);
            setSelectedOption(value);
          }}
          selected={selectedOption}
          options={options}
          aria-label={`List of tribes. ${options.length} items available.`}
        />

Before:
Screenshot 2023-09-19 at 3 25 11 PM

After:
Screenshot 2023-09-19 at 3 25 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve screen-reader accessibility of VuiPopover, VuiSearchSelect, and other popovers
1 participant