Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not resolve dependency with [email protected] #243

Open
Ryxuu opened this issue Mar 27, 2024 · 3 comments
Open

Could not resolve dependency with [email protected] #243

Ryxuu opened this issue Mar 27, 2024 · 3 comments

Comments

@Ryxuu
Copy link

Ryxuu commented Mar 27, 2024

Describe the bug and the expected behaviour
I am using [email protected]. When I try to istall @signpdf/placeholder-pdfkit the installation process fails with

npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/pdfkit
npm ERR!   pdfkit@"^0.15.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer pdfkit@"^0.11.0" from @signpdf/[email protected]
npm ERR! node_modules/@signpdf/placeholder-pdfkit
npm ERR!   @signpdf/placeholder-pdfkit@"*" from the root project

Is it a bug in signing or in the helpers?
It shows up with placeholder-pdfkit helper.

To Reproduce
Using pdfKit with version greater than 0.11.0 the dependency error appears if you try to install placeholder-pdfkit.

@Dmitrijs-Sakovics
Copy link

this is a quirk of Semantic Versioning: placeholder-pdfkit has a peer dependency of pdfkit "^0.11.0", which means "0.11.x" (because the version is lower than "1.0.0")

to allow all versions "0.x.y" for x>=11, you actually want the reference to be something like ">=0.11.0 <1.0.0"

@vbuch
Copy link
Owner

vbuch commented Mar 27, 2024

We have to fix that

@tfrancois
Copy link

Not sure if this is related, but adding the @signpdf/placeholder-plain to my project adds 118 packages! Not seeing where in the dependency tree of the packages specified in the package.json of either ...plain and ...pdfkit010 that all of these dependencies are necessary. That kind of bloat significantly forced me to revert to using the pdf-lib placeholder implementation even though it doesn't support multiple signers. Please help and advise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants