Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish the struct conversion #3

Open
vbfox opened this issue Apr 27, 2015 · 1 comment
Open

Finish the struct conversion #3

vbfox opened this issue Apr 27, 2015 · 1 comment
Assignees
@vbfox
Labels
bug enhancement

Comments

@vbfox
Copy link
Owner

vbfox commented Apr 27, 2015

As the Id type is now a stuct all the current code need to be re-evaluated in this light
@vbfox vbfox self-assigned this Apr 27, 2015
@vbfox
Copy link
Owner Author

vbfox commented Apr 27, 2015

A point to correctly handle is that the underlying value can now always be null if the type is nullable.

So code like :

        public override int GetHashCode()
        {
            return Value.GetHashCode();
        }

Should not be generated.

vbfox added a commit that referenced this issue May 1, 2015
@vbfox
Handle null value in IConvertible implementation
1726ce6 
Null values are now passed to Convert.ToXXX or
Convert.ChangeType instead of throwing an exception.

Related to #3
@vbfox vbfox mentioned this issue Jun 3, 2015
Closed
@vbfox vbfox assigned vbfox and unassigned vbfox Jun 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vbfox vbfox

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vbfox