From 4fb0e80f0ed2a71d9bf3f693f5e845bd1cb3a265 Mon Sep 17 00:00:00 2001 From: Joy John Pinto <86055382+pintojoy@users.noreply.github.com> Date: Wed, 6 Sep 2023 15:05:18 +0530 Subject: [PATCH] Fixing test_node_replacement tests for Vmware IPI platforms (#8375) Due to regression from #7510 node replacement tests were failing for Vmware IPI platform Signed-off-by: pintojoy --- .../z_cluster/nodes/test_node_replacement_proactive.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/manage/z_cluster/nodes/test_node_replacement_proactive.py b/tests/manage/z_cluster/nodes/test_node_replacement_proactive.py index 84775cb158f..69f07013674 100644 --- a/tests/manage/z_cluster/nodes/test_node_replacement_proactive.py +++ b/tests/manage/z_cluster/nodes/test_node_replacement_proactive.py @@ -69,9 +69,12 @@ def check_node_replacement_verification_steps( f"of osd nodes. Wait for the new created worker node to appear in the osd nodes" ) timeout = 1500 - # In vSphere platform, we are creating new node with same name as deleted + # In vSphere UPI platform, we are creating new node with same name as deleted # node using terraform - if config.ENV_DATA["platform"].lower() == constants.VSPHERE_PLATFORM: + if ( + config.ENV_DATA["platform"].lower() == constants.VSPHERE_PLATFORM + and config.ENV_DATA["deployment_type"] == "upi" + ): new_osd_node_name = old_node_name else: new_osd_node_name = node.wait_for_new_osd_node(old_osd_node_names, timeout)