Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual coalesce for a VM #7757

Open
olivierlambert opened this issue Jun 20, 2024 · 3 comments · Fixed by #7810
Open

Manual coalesce for a VM #7757

olivierlambert opened this issue Jun 20, 2024 · 3 comments · Fixed by #7810

Comments

@olivierlambert
Copy link
Member

See https://docs.xenserver.com/en-us/xenserver/8/storage/manage.html#reclaim-space-by-using-the-offline-coalesce-tool

In Advanced view, a "Manual coalesce" button that will show a popup "The VM will be suspended during the operation".

Then:

  1. Suspend the VM
  2. Start the command
  3. Unsuspend when finished
@julien-f
Copy link
Member

julien-f commented Nov 18, 2024

@olivierlambert: @Wescoeur and @Nambrok think it's a bad idea to expose this feature to the user.

Related to zammad#31426

@julien-f julien-f reopened this Nov 18, 2024
@Wescoeur
Copy link
Member

The coalesce-leaf plugin has many limitations:

  • Can only be called on LVM SRs.
  • Can only be run on a VHD chain length of 2.
  • No start/resume should be executed during forced coalesce execution. There is no security guaranteed by this script.

@julien-f
Copy link
Member

@Wescoeur How does the plugin behave if the conditions are not fulfilled?

What should we do?

  • remove the button entirely?
  • add a confirm modal to indicate limitations?
  • only allow the action in XO if the conditions are fulfilled? (something I'm not fond of)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment